This repository has been archived by the owner on Oct 3, 2021. It is now read-only.
Remove some warning suppression flags and lay the ground work for treating some warnings as errors #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
November 4, 2015 12:26
…ion flags" This reverts commit 4815a22. This isn't necessary anymore since the benchmarks in ldv-consumption have been fixed.
``-Wno-return-type``.
that we can have certain warnings treated as errors. Now we no longer suppress -Wmain and instead pass -Werror=main so that incorrect main() functions trigger a compiler error instead of a warning.
without -Wno-return-type
is a good indicator of bad code.
justifiable as it likely means there is undefined behaviour.
-Werror=implicit-int. I tried adding these but the benchmarks don't compile with these set and it looks like a lot of work to fix these.
delcypher
changed the title
Closed
dbeyer
added a commit
that referenced
this pull request
Nov 4, 2015
Remove some warning suppression flags and lay the ground work for treating some warnings as errors
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
-Wno-return-type.-Werror=mainas an example.Ideally I'd like to add
-Werror=implicit-function-declarationand-Werror=implicit-intbut unfortunately it looks like the benchmarks are littered with violations of these.